Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contao-merge-cache-control header is exposed #1959

Closed
Toflar opened this issue Jul 22, 2020 · 3 comments · Fixed by #2122
Closed

contao-merge-cache-control header is exposed #1959

Toflar opened this issue Jul 22, 2020 · 3 comments · Fixed by #2122
Labels
bug
Milestone
4.9

Comments

@Toflar
Copy link
Member

Toflar commented Jul 22, 2020

Affected version(s)

4.9?

Description

Not a big deal but that info shouldn't be public so we should remove that.
@Toflar Toflar added the bug label Jul 22, 2020
@Toflar Toflar added this to the 4.9 milestone Jul 22, 2020
@leofeyer
Copy link
Member

leofeyer commented Aug 5, 2020

Can we remove it here or do we need a separate method?

contao/core-bundle/src/EventListener/SubrequestCacheSubscriber.php

Lines 83 to 85 in 51e8453

if ($isMasterRequest) {
$this->currentStrategy = array_pop($this->strategyStack);
}

@Toflar
Copy link
Member Author

Toflar commented Aug 5, 2020

/cc @aschempp

@aschempp
Copy link
Member

aschempp commented Aug 5, 2020

I think we can, yes

@leofeyer leofeyer mentioned this issue Aug 7, 2020
Merged
@leofeyer leofeyer linked a pull request Aug 7, 2020 that will close this issue
Remove the Contao-Merge-Cache-Control header in the master request #2122
Merged
@leofeyer leofeyer closed this as completed Aug 7, 2020
leofeyer added a commit that referenced this issue Aug 7, 2020
@leofeyer
Remove the Contao-Merge-Cache-Control header in the master request (see
4b882d8 
#2122)

Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | Fixes #1959
| Docs PR or issue | -

Commits
-------

c02be77 Remove the Contao-Merge-Cache-Control header in the master request
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging a pull request may close this issue.

Remove the Contao-Merge-Cache-Control header in the master request leofeyer/contao
3 participants
@Toflar @aschempp @leofeyer