Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace patchwork/utf8 with symfony/string #2630

Closed
leofeyer opened this issue Jan 12, 2021 · 2 comments · Fixed by #3530
Closed

Replace patchwork/utf8 with symfony/string #2630

leofeyer opened this issue Jan 12, 2021 · 2 comments · Fixed by #3530
Labels
feature
Milestone
4.13

Comments

@leofeyer
Copy link
Member

We should switch to symfony/string as soon as Contao is Symfony 5 only: Package patchwork/utf8 is abandoned, you should avoid using it. Use symfony/polyfill-mbstring or symfony/string instead.
@leofeyer leofeyer added this to the 4.12 milestone Jan 12, 2021
@m-vo
Copy link
Member

m-vo commented Jan 12, 2021

I think we could already move to symfony/string. This is imho independent of Sf 5.

@Toflar
Copy link
Member

Toflar commented Jan 12, 2021

I agree, there's no reason to wait. Anybody using Utf8 should be requiring the package themselves and they do not conflict :)

@leofeyer leofeyer modified the milestones: 4.12, 4.13 Jul 1, 2021
@leofeyer leofeyer mentioned this issue Sep 30, 2021
Merged
@leofeyer leofeyer linked a pull request Sep 30, 2021 that will close this issue
Replace patchwork/utf8 with symfony/string #3530
Merged
leofeyer added a commit that referenced this issue Oct 6, 2021
@leofeyer
Replace patchwork/utf8 with symfony/string (see #3530)
267ef46 
Description
-----------

| Q                | A
| -----------------| ---
| Implemented issue     | #2630
| Docs PR or issue | -

Contao now uses `mb_` functions (optionally made available by `symfony/polyfill-mbstring`) for casing and length and `symfony/string` for transliterating.

Commits
-------

edae833 Replace patchwork/utf8 with symfony/string
5382672 Fix the CI chain
17882bf Add a missing dependency
@dennisbohn dennisbohn mentioned this issue Feb 1, 2022
Closed
@MDevster MDevster mentioned this issue Mar 14, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
4.13
Development

Successfully merging a pull request may close this issue.

Replace patchwork/utf8 with symfony/string leofeyer/contao
3 participants
@Toflar @leofeyer @m-vo