Contao 4.12-RC1 Error invoking template editor

[Seefahrer]

Contao 4.12-RC1:

Description

Invoking the template editor in the backend causes fllwg error message:

request.CRITICAL: Uncaught PHP Exception ValueError: "func_get_arg(): Argument #1 ($position) must be less than the number of the arguments passed to the currently executed function" at /Users/georg/Websites/cmsc4ME/var/cache/prod/contao/dca/tl_templates.php line 345 {"exception":"[object] (ValueError(code: 0): func_get_arg(): Argument #1 ($position) must be less than the number of the arguments passed to the currently executed function at /Users/georg/Websites/cmsc4ME/var/cache/prod/contao/dca/tl_templates.php:345)"} []

[fritzmg]

I could not reproduce the problem. @Seefahrer enable the debug mode and post the stack trace for more information.

[ausi]

As the error message shows line 345 of the cached tl_templates.php file I would assume that the relevant code comes from an extension or a DCA file of the application.

@Seefahrer do you have any extensions installed?

[Seefahrer]

Installed extensions as per composer.json:

"bugbuster/contao-visitors-bundle": "^1.7",
"contao/conflicts": "*@dev",
"contao/manager-bundle": "^4.12",
"do-while/contao-ticker-bundle": "^1.1",
"fritzmg/contao-lightcase": "dev-master",
"inspiredminds/contao-wowjs": "^1.1",
"jrgregory/m17-sticky-backend-footer": "^2.0",
"madeyourday/contao-rocksolid-custom-elements": "^2.2",
"madeyourday/contao-rocksolid-frontend-helper": "^2.0",
"madeyourday/contao-rocksolid-icon-picker": "^2.0",
"madeyourday/contao-rocksolid-slider": "^2.0",
"oveleon/contao-cookiebar": "^1.9“,
"terminal42/contao-ajaxform": "^1.0",
"terminal42/contao-changelanguage": "^3.1",
"terminal42/contao-easy_themes": "^2.2“

stack trace:

`
ErrorException:
Warning: Undefined array key "TL_EASY_THEMES_MODULES"

at vendor/terminal42/contao-easy_themes/config/config.php:65
at include('/Users/georg/Websites/carlito/vendor/terminal42/contao-easy_themes/config/config.php')
(vendor/contao/core-bundle/src/Resources/contao/library/Contao/Config.php:179)
at Contao\Config->initialize()
(vendor/contao/core-bundle/src/Resources/contao/library/Contao/Config.php:144)
at Contao\Config::getInstance()
(vendor/contao/core-bundle/src/Framework/Adapter.php:44)
at Contao\CoreBundle\Framework\Adapter->__call('getInstance', array())
(vendor/contao/core-bundle/src/Framework/ContaoFramework.php:301)
at Contao\CoreBundle\Framework\ContaoFramework->initializeFramework()
(vendor/contao/core-bundle/src/Framework/ContaoFramework.php:158)
at Contao\CoreBundle\Framework\ContaoFramework->initialize()
(vendor/contao/core-bundle/src/Security/User/ContaoUserProvider.php:69)
at Contao\CoreBundle\Security\User\ContaoUserProvider->loadUserByUsername('Georg')
(vendor/contao/core-bundle/src/Security/User/ContaoUserProvider.php:88)
at Contao\CoreBundle\Security\User\ContaoUserProvider->refreshUser(object(BackendUser))
(vendor/symfony/security-http/Firewall/ContextListener.php:216)
at Symfony\Component\Security\Http\Firewall\ContextListener->refreshUser(object(UsernamePasswordToken))
(vendor/symfony/security-http/Firewall/ContextListener.php:131)
at Symfony\Component\Security\Http\Firewall\ContextListener->authenticate(object(RequestEvent))
(vendor/symfony/security-bundle/Debug/WrappedLazyListener.php:49)
at Symfony\Bundle\SecurityBundle\Debug\WrappedLazyListener->authenticate(object(RequestEvent))
(vendor/symfony/security-http/Firewall/AbstractListener.php:26)
at Symfony\Component\Security\Http\Firewall\AbstractListener->__invoke(object(RequestEvent))
(vendor/symfony/security-bundle/Debug/TraceableFirewallListener.php:62)
at Symfony\Bundle\SecurityBundle\Debug\TraceableFirewallListener->callListeners(object(RequestEvent), object(Generator))
(vendor/symfony/security-http/Firewall.php:86)
at Symfony\Component\Security\Http\Firewall->onKernelRequest(object(RequestEvent), 'kernel.request', object(TraceableEventDispatcher))
(vendor/symfony/event-dispatcher/Debug/WrappedListener.php:117)
at Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke(object(RequestEvent), 'kernel.request', object(TraceableEventDispatcher))
(vendor/symfony/event-dispatcher/EventDispatcher.php:230)
at Symfony\Component\EventDispatcher\EventDispatcher->callListeners(array(object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener)), 'kernel.request', object(RequestEvent))
(vendor/symfony/event-dispatcher/EventDispatcher.php:59)
at Symfony\Component\EventDispatcher\EventDispatcher->dispatch(object(RequestEvent), 'kernel.request')
(vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:151)
at Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch(object(RequestEvent), 'kernel.request')
(vendor/symfony/http-kernel/HttpKernel.php:133)
at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
(vendor/symfony/http-kernel/HttpKernel.php:79)
at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
(vendor/symfony/http-kernel/Kernel.php:195)
at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
(web/index.php:31) `

[bytehead]

easy themes is not php8 compatible as far as I know.

[ausi]

The stack trace is from a different error/warning: Undefined array key "TL_EASY_THEMES_MODULES"

The error from your original post is func_get_arg(): Argument #1 ($position) must be less than the number of the arguments passed to the currently executed function

[Seefahrer]

it’s the only stack trace I can provide. The error is obviously not caused by Easy_Themes.
Removal of Easy_Themes did not solve the issue ...

[fritzmg]

it’s the only stack trace I can provide. The error is obviously not caused by Easy_Themes.

You need to first solve the warning from that extension.

Removal of Easy_Themes did not solve the issue ...

Now you should be able to provide the stack trace for your original error (unless there is another Warning before that).

[Seefahrer]

Many thanks for the info!

Stack trace now:

`
ValueError:
func_get_arg(): Argument #1 ($position) must be less than the number of the arguments passed to the currently executed function

at vendor/contao/core-bundle/src/Resources/contao/dca/tl_templates.php:590
at func_get_arg(12)
(vendor/contao/core-bundle/src/Resources/contao/dca/tl_templates.php:590)
at tl_templates->editSource(array('id' => 'templates/freestyle-fx', 'fileNameEncoded' => 'freestyle-fx', 'type' => 'folder'), 'act=source', 'Den Quelltext der Datei "templates/freestyle-fx" bearbeiten', 'Den Quelltext der Datei "templates/freestyle-fx" bearbeiten', 'editor.svg', ' class="source"')
(vendor/madeyourday/contao-rocksolid-custom-elements/src/Resources/contao/dca/tl_templates.php:27)
at Contao\DcaLoader->{closure}(array('id' => 'templates/freestyle-fx', 'fileNameEncoded' => 'freestyle-fx', 'type' => 'folder'), 'act=source', 'Den Quelltext der Datei "templates/freestyle-fx" bearbeiten', 'Den Quelltext der Datei "templates/freestyle-fx" bearbeiten', 'editor.svg', ' class="source"', 'tl_templates', array(), null, false, null, null, object(DC_Folder))
(vendor/contao/core-bundle/src/Resources/contao/classes/DataContainer.php:813)
at Contao\DataContainer->generateButtons(array('id' => 'templates/freestyle-fx', 'fileNameEncoded' => 'freestyle-fx', 'type' => 'folder'), 'tl_templates')
(vendor/contao/core-bundle/src/Resources/contao/drivers/DC_Folder.php:2814)
at Contao\DC_Folder->generateTree('/Users/georg/Websites/carlito/templates', 0, false, true, false, array())
(vendor/contao/core-bundle/src/Resources/contao/drivers/DC_Folder.php:441)
at Contao\DC_Folder->showAll()
(vendor/contao/core-bundle/src/Resources/contao/classes/Backend.php:648)
at Contao\Backend->getBackendModule('tpl_editor', null)
(vendor/contao/core-bundle/src/Resources/contao/controllers/BackendMain.php:167)
at Contao\BackendMain->run()
(vendor/contao/core-bundle/src/Controller/BackendController.php:49)
at Contao\CoreBundle\Controller\BackendController->mainAction()
(vendor/symfony/http-kernel/HttpKernel.php:157)
at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
(vendor/symfony/http-kernel/HttpKernel.php:79)
at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
(vendor/symfony/http-kernel/Kernel.php:195)
at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
(web/index.php:31) `

[m-vo]

Could it be the button callback here not including all parameters so that a func_get_arg(12) fails?

Seems func_get_arg fails even if the parameters are optional: https://3v4l.org/sAE40#v8.0.9

[ausi]

IMO this is a PHP 8 error on line

contao/core-bundle/src/Resources/contao/dca/tl_templates.php

Line 590 in 40b7f16

$dc = (@func_get_arg(12) ?: null);

We have to check func_num_args() first there I think.

Silencing with @ works in PHP 7, but not PHP 8.

[ausi]

Same in

contao/core-bundle/src/Resources/contao/dca/tl_files.php

Line 804 in 40b7f16

$dc = (@func_get_arg(12) ?: null);

[m-vo]

🙈

[ausi]

I will make a PR.

[ausi]

Closed in favor of #3243 and #3245

[ausi]

@Seefahrer thank you for testing the RC version!