Got rid of the header-replay-bundle #365
Conversation
| $this->addSubscriber(new CleanupCacheTagsListener()); | ||
| } | ||
|
|
||
| public function wasCacheCircumvented(): bool |
There was a problem hiding this comment.
You might wonder why I did not mock the kernel and check if ->handle() was called or not. I did do this initially but it doesn't really work. I only want to check if our ContaoCache does what it's supposed to do. If a private request comes in ->kernel->handle() should not be called, thus you would set ->expects($this->never()) but that will actually not work because the request will flow through the HttpCache that has no cache entry eventually being forward()ed again to the the kernel so that expectation would fail 馃槃
|
The one failing test is unrelated and also happens in master. |
|
Thank you @Toflar. And thank you for having created the header-replay-bundle in the first place 鈥撀爄t was a good solution for a problem that we could not have fixed at the time otherwise. |
Well, here we are. It's been a nice ride dear
header-replay-bundle. You've taught us a lot about caching but it's time to make Contao faster and easier to debug and understand.Thank you for your service over the last two years.
Bye, bye 馃憢