Incompatibility between DCA constants and the universal picker

[doishub]

Affected version(s)

4.9.28

Description

While researching this ticket, I noticed an inconsistency which occurs when an external extension uses the picker widget but not the new DCA constants.

The following line of code only checks for the constant, so DCAs that are still defined as 'Table' (string) and want to be called by a picker widget are no longer compatible with the current Contao version 4.9.28:

contao/core-bundle/src/Picker/AbstractTablePickerProvider.php

Line 139 in 3580632

return $this->getDataContainer() === $GLOBALS['TL_DCA'][$table]['config']['dataContainer']

Or in TablePickerProvider:

contao/core-bundle/src/Picker/TablePickerProvider.php

Lines 24 to 27 in 3580632

	protected function getDataContainer(): string
	{
	return DC_Table::class;
	}

If I would now adjust the extension accordingly, all running Contao instances (<4.9.28) that exclusively install the latest version of the extension would no longer work.

Is this behavior desired? I would have expected some kind of BC layer here now.

[bytehead]

Will be fixed by #4481 🙃

[bytehead]

Use Contao\DC_Table::class instead of Table in your DCA definition ($GLOBALS['TL_DCA'][$table]['config']['dataContainer']).

[bytehead]

Closing in favor of #4481, thank you for reporting though 🙏

[doishub]

Use Contao\DC_Table::class instead of Table in your DCA definition ($GLOBALS['TL_DCA'][$table]['config']['dataContainer']).

Hm, then I have the described case here or am I thinking wrong?

If I would now adjust the extension accordingly, all running Contao instances (<4.9.28) that exclusively install the latest version of the extension would no longer work.

[fritzmg]

That's not really an issue. The new version of your extension can just require "contao/core-bundle": "^4.9.28".

[doishub]

I thought I could do without this dependency, but then I will implement it that way or wait for the fix. Thank you 🙃

[bytehead]

You could also add a conflict with "contao/core-bundle": "4.9.28".

[fritzmg]

I thought I could do without this dependency, but then I will implement it that way or wait for the fix. Thank you 🙃

There is no downside to defining your dependency this way.

[doishub]

Except that Contao instances which have to run on an older 4.9 (for whatever reason) can't use the extension anymore. I think I will wait for the fix and use a conflict. In the long run the constants will be used in any case.

[fritzmg]

Except that Contao instances which have to run on an older 4.9 (for whatever reason) can't use the extension anymore.

Why not? They will automatically get a version of your extension that is compatible.

I think I will wait for the fix and use a conflict.

But for the conflict to take effect you have to create a new version anyway.

[aschempp]

#4711 fixes the inconsistency