Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly support legacy DC names in picker provider #4711

Merged
merged 2 commits into from May 31, 2022
Merged

Correctly support legacy DC names in picker provider #4711

merged 2 commits into from May 31, 2022

Conversation

aschempp
Copy link
Member

The changes in #4481 lead to breaking support for DCA and picker with the legacy name.

FYI we don't need to trigger a deprecation for comparing the old name, because calling DataContainer::getDriverForTable already does that.

@aschempp aschempp added the bug label May 23, 2022
@aschempp aschempp added this to the 4.9 milestone May 23, 2022
@aschempp aschempp requested review from bytehead and a team May 23, 2022 09:02
@aschempp aschempp self-assigned this May 23, 2022
@aschempp aschempp marked this pull request as ready for review May 23, 2022 09:02
@aschempp aschempp mentioned this pull request May 23, 2022
Closed
@Toflar
Copy link
Member

Toflar commented May 23, 2022

We should add a todo though to remove it again in the 5.x branch.

@fritzmg
Copy link
Contributor

fritzmg commented May 23, 2022

Why is this necessary? According to the doc $this->getDataContainer() always returns the FQCN.

@aschempp
Copy link
Member Author

Yes, but $this->getDataContainer() might return the old string name

@aschempp aschempp mentioned this pull request May 23, 2022
Closed
@bytehead
Copy link
Member

Yes, but $this->getDataContainer() might return the old string name

In which cases? May we should add a test for this.

@leofeyer leofeyer linked an issue May 24, 2022 that may be closed by this pull request
Incompatibility between DCA constants and the universal picker #4496
Closed
@leofeyer leofeyer removed a link to an issue May 24, 2022
Incompatibility between DCA constants and the universal picker #4496
Closed
@aschempp
Copy link
Member Author

In which cases?

If an extension supports Contao versions before we added support for FQCN table names, it must use the legacy name both in the DCA file as well as the picker implementation.

@leofeyer leofeyer enabled auto-merge (squash) May 31, 2022 09:43
@leofeyer leofeyer merged commit cd6d05b into contao:4.9 May 31, 2022
@aschempp aschempp deleted the bugfix/datacontainer branch May 31, 2022 09:44
@leofeyer leofeyer changed the title Correctly support legacy DC name in picker provider Correctly support legacy DC names in picker provider Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

@bytehead bytehead Awaiting requested review from bytehead

Assignees

@aschempp aschempp

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aschempp @Toflar @fritzmg @bytehead @leofeyer