Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of labels for settings / for edit #509

Closed
Metis77 opened this issue May 10, 2019 · 7 comments
Closed

Naming of labels for settings / for edit #509

Metis77 opened this issue May 10, 2019 · 7 comments
Labels

Comments

@Metis77
Copy link

Metis77 commented May 10, 2019

Description
My customer always are completely confused about the difference of those editing settings and editing content label names.
I also think, that the naming is far from self-explanatory.

Therefor I suggest to change the naming of those icons simply to:

  • edit content / settings
    or in german
  • Inhalte bearbeiten / Einstellungen

This means, drop the ID and the name of the thing like "event" or "article".
Just short and simply as suggested above.

Example
Hier beispielhaft wie es gerade ist:
naming

@bytehead
Copy link
Member

I do like to see the ID of an element quickly on hover (e.g. for referencing in an insert tag or the like).

@Metis77
Copy link
Author

Metis77 commented May 10, 2019

@bytehead
You are right, but those infos are available anyway:
id

The usual user does not even know, what IDs are and is simply confused by all the info and the naming of the edit and setting icons.

This makes my customers often use those completely wrong.
For example they often just use the teaser text in the settings of events. They simply do forget / do not see that the actual content should be entered separately by clicking the edit icon.

I think a simple naming would help a lot.
Just make it "edit content" and "settings".

@fritzmg
Copy link
Contributor

fritzmg commented May 10, 2019

@Metis77 please create new issues in the mono repository.

There is a related discussion (can't find the issue right now) about the edit button. Currently, the pen icon is used sometimes for "edit settings" and sometimes for "edit child elements". Imho that's the main problem, not the wording of the tooltip.

@xchs
Copy link
Contributor

xchs commented May 10, 2019

There is a related discussion (can't find the issue right now) about the edit button.

https://github.com/contao/core/issues/8821

@fritzmg
Copy link
Contributor

fritzmg commented May 10, 2019

@leofeyer
Copy link
Member

leofeyer commented Jun 6, 2019

As discussed in Mumble on June 6th, we want "Einstellungen bearbeiten" and "Element ID … bearbeiten" as default label, so the label key can be omitted in the DCA. (If the label is defined, it shall still be used.)

@leofeyer leofeyer transferred this issue from contao/core-bundle Jun 6, 2019
@leofeyer leofeyer added this to the 4.8 milestone Jun 6, 2019
@leofeyer
Copy link
Member

See #532.

@leofeyer leofeyer removed this from the 4.8 milestone Jun 24, 2019
leofeyer added a commit that referenced this issue Jun 25, 2019
Description
-----------

This PR implements the changes discussed in #509.

1. It is no loner necessary to add the `label` key in the DCA for (global) operations and fields. It will be set automatically if not given.

2. <del>It is possible to define a special `_element` label per table, which will be used to replace the word "element" with the label content, so e.g. "edit element ID 2" becomes "edit user group ID 2".</del>

3. The `alt` tags of the IMG elements are now the same as the `title` tags of the A elements, which fixes the accessibility of the buttons (see https://ux.stackexchange.com/a/92259).

@contao/developers Let me know if you like the concept, then I will complete the PR.

### TODO

* [x] XLIFF files
* [x] Other bundles

Commits
-------

946dfe8 Use generic labels in DCAs
96ecc84 Remove unused labels from the core-bundle language files
4f5ff38 Remove unused labels from the other bundles
4b58e5d Fix some minor issues
c8b6e62 Use references in the `addDefaultLabels()` method
bcf5e4f Correctly check for circular references when moving files and folders
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants