Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The request token is replaced only sporadically #5161

Closed
netzarbeiter opened this issue Aug 16, 2022 · 6 comments
Closed

The request token is replaced only sporadically #5161

netzarbeiter opened this issue Aug 16, 2022 · 6 comments

Comments

@netzarbeiter
Copy link
Member

Affected version(s)

4.9.32

Description

After updating to 4.9.32, the request token in an Isotope reader module is only replaced sporadically.

https://github.com/isotope/core/blob/2.8/system/modules/isotope/templates/isotope/iso_reader_default.html5#L4

If I put a product in the shopping cart and want to add another one, I land on the error page "Invalid request token".

The request token is not replaced in the front end.

<input type="hidden" name="REQUEST_TOKEN" value="{{request_token}}">
@leofeyer leofeyer added this to the 4.9 milestone Aug 16, 2022
@aschempp
Copy link
Member

Looks like it does no longer happen automatically for ajax requests? 🤔

@ausi
Copy link
Member

ausi commented Aug 16, 2022

Can this be reproduced without Isotope?
Does downgrading to Contao 4.9.31 fix the issue?

@netzarbeiter
Copy link
Member Author

Downgrading to Contao 4.9.31 fixed the issue for me.

@fritzmg
Copy link
Contributor

fritzmg commented Aug 16, 2022

@netzarbeiter can you test if #5130 may be fixes the issue? (The change within vendor/core-bundle/src/Framework/ContaoFramework.php should be sufficient for testing.)

@netzarbeiter
Copy link
Member Author

The changes have no effect on the behaviour.

@aschempp
Copy link
Member

This is actually a problem of Isotope 2.8.6 and not Contao. isotope/core@1b7b15b#diff-72afebad9a00277ea35fef7ddf8851956b83d644d5d9a155a811e12ec3ac7a10 changed the response handling from Haste to Symfony, but Symfony (obviously) does not replace insert tags on the response. I'll provide a fix in Isotope.

aschempp added a commit to isotope/core that referenced this issue Aug 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants