Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax Requests should probably check for a valid session #5865

Closed
asaage opened this issue Mar 10, 2023 · 1 comment · Fixed by #5868
Closed

Ajax Requests should probably check for a valid session #5865

asaage opened this issue Mar 10, 2023 · 1 comment · Fixed by #5868
Labels

Comments

@asaage
Copy link

asaage commented Mar 10, 2023

Affected version(s)

4.13

Description

Lets pretend you have a BE-Page open in your browser and for whatever reason your session has expired.
You are still "able" to hide/unhide elements and get (fake)feedback in the form of an icon colorchange. The invalid session does not reveal itself at this point.

@Toflar
Copy link
Member

Toflar commented Mar 10, 2023

I can confirm. We just swap the eye image and the request fails. There might be tons of other such cases so I guess best would be to redirect to the login page. Here's a quick attempt: #5868

@leofeyer leofeyer linked a pull request Mar 13, 2023 that will close this issue
leofeyer added a commit that referenced this issue Mar 14, 2023
Description
-----------

Fixes #5865

Just a quick attempt to fix this issue in a general manner. Not sure if that's the best way to go but we'll see :) 

Commits
-------

a3b90aa Always redirect to the back end in case of ajax requests and an expir…
3d09ed3 Adjust implementation
346805f CS

Co-authored-by: Leo Feyer <1192057+leofeyer@users.noreply.github.com>
leofeyer added a commit to contao/core-bundle that referenced this issue Mar 14, 2023
Description
-----------

Fixes contao/contao#5865

Just a quick attempt to fix this issue in a general manner. Not sure if that's the best way to go but we'll see :) 

Commits
-------

a3b90aaa Always redirect to the back end in case of ajax requests and an expir…
3d09ed32 Adjust implementation
346805f2 CS

Co-authored-by: Leo Feyer <1192057+leofeyer@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants