Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Row format check misses file format check #59

Closed
leofeyer opened this issue Sep 14, 2018 · 2 comments
Closed

Row format check misses file format check #59

leofeyer opened this issue Sep 14, 2018 · 2 comments
Assignees
@leofeyer
Labels
bug
Milestone
4.6

Comments

@leofeyer
Copy link
Member

When checking the row format, we must also check whether the file format supports dynamic rows.

contao/installation-bundle/src/Database/Installer.php

Lines 202 to 207 in cf6e34a

if (strtolower($tableOptions->Engine) !== strtolower($engine)) {
if ($innodb) {
$command = 'ALTER TABLE '.$tableName.' ENGINE = '.$engine.' ROW_FORMAT = DYNAMIC';
} else {
$command = 'ALTER TABLE '.$tableName.' ENGINE = '.$engine;
}

@leofeyer leofeyer added the bug label Sep 14, 2018
@leofeyer leofeyer added this to the 4.6.4 milestone Sep 14, 2018
@leofeyer leofeyer self-assigned this Sep 14, 2018
leofeyer added a commit that referenced this issue Sep 14, 2018
@leofeyer
[Installation] Check wether the database supports dynamic rows in the…
acb6000 
… install tool (see #59)
@leofeyer
Copy link
Member Author

leofeyer commented Sep 14, 2018 •
edited

Fixed in acb6000. @fritzmg /cc

@xchs
Copy link
Contributor

xchs commented Sep 15, 2018

It works for me.

@leofeyer leofeyer modified the milestones: 4.6.4, 4.6 May 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.6
Development

No branches or pull requests
2 participants
@leofeyer @xchs