Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong images/icons on darkmode on publish/unpublish #6869

Closed
zoglo opened this issue Feb 8, 2024 · 1 comment · Fixed by #6880
Closed

Wrong images/icons on darkmode on publish/unpublish #6869

zoglo opened this issue Feb 8, 2024 · 1 comment · Fixed by #6880
Labels

Comments

@zoglo
Copy link
Contributor

zoglo commented Feb 8, 2024

Affected version(s)

5.2.x, 5.3.x

Description

When publishing / unpublishing any item, the images are not properly loaded. It will use the lightmode images.

See:
image

@zoglo
Copy link
Contributor Author

zoglo commented Feb 8, 2024

I'd look into that right now and share my information about that.

leofeyer pushed a commit that referenced this issue Feb 13, 2024
…see #6880)

Description
-----------

Fixes #6869

___

**Description**

I extract the incoming data-attributes and properly distribute them for the two states now, this has been missing before.
Attributes get merged again but I remove the data-icons from the HtmlAttributes before doing so.

___

**Edit**
- Just replacing the icon sources within darkAttributes works

Commits
-------

00bb310 Consider data-themes in `data-icon` and `data-icon-disabled`
55134ef Restore `strpos` (legacy)
cbd2b71 Merge remote-tracking branch 'origin/bugfix/icons-dark-mode' into bug…
36d2d9b Run the tests again
f3a0827 Update image library
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants