Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

401 page can't be moved in page structure #7116

Closed
operatorone opened this issue Apr 15, 2024 · 4 comments · Fixed by #7168
Closed

401 page can't be moved in page structure #7116

operatorone opened this issue Apr 15, 2024 · 4 comments · Fixed by #7168
Labels
bug
Milestone
5.3

Comments

@operatorone
Copy link

Affected version(s)

5.3.4

Description

I tried to move the just created 401 page in the page structure, but the clipboard stays grey after cliking the blue move button.

See
Uploading 2024-04-15 at 14.02.12.jpg…
image
@fritzmg
Copy link
Contributor

fritzmg commented Apr 15, 2024 •
edited

I can confirm the issue.

To be clear: what is not working is moving the page within the same website root, which should always be possible. Moving to other website roots works - depending on whether a 401 page is already there or not.

I assume this check just needs to be adjusted so that it excludes the current website root of the page.

@fritzmg fritzmg added this to the 5.3 milestone Apr 15, 2024
@leofeyer
Copy link
Member

Is this a duplicate of #7095?

@fritzmg
Copy link
Contributor

fritzmg commented Apr 15, 2024 •
edited

#7095 does not fix this issue at least, as far as I tested.

@aschempp aschempp mentioned this issue Apr 30, 2024
Merged
@aschempp
Copy link
Member

see #7168

@leofeyer leofeyer linked a pull request Apr 30, 2024 that will close this issue
Allow to move an error page within its root #7168
Merged
leofeyer pushed a commit that referenced this issue May 2, 2024
@aschempp
Allow to move an error page within its root (see #7168)
b6f7529 
Description
-----------

Fixes #7116

Commits
-------

a4c8e06 Allow to move an error page within its root
e9eb53d Update core-bundle/src/Security/Voter/DataContainer/PageTypeAccessVot…
leofeyer pushed a commit to contao/core-bundle that referenced this issue May 2, 2024
@aschempp
Allow to move an error page within its root (see #7168)
c1cb89e 
Description
-----------

Fixes contao/contao#7116

Commits
-------

a4c8e068 Allow to move an error page within its root
e9eb53d3 Update core-bundle/src/Security/Voter/DataContainer/PageTypeAccessVot…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging a pull request may close this issue.

Allow to move an error page within its root aschempp/contao
4 participants
@aschempp @leofeyer @operatorone @fritzmg