Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of backend modules changed after updating system in Contao Manager #970

Closed
juju2 opened this issue Nov 13, 2019 · 3 comments
Closed

Order of backend modules changed after updating system in Contao Manager #970

juju2 opened this issue Nov 13, 2019 · 3 comments

Comments

@juju2
Copy link

juju2 commented Nov 13, 2019

Affected version(s)
4.4.45 (at least)

Description
After e.g. uninstalling a backend module or updating an extension via Contao Manager the order of backend modules underneath the headline "Content" has changed in the Contao backend menu.

The Events for example by default are at position 3 (after Articles and News) and after making the described changes the order changes to Articles, Events, News, ...

I testet making a downgrade to Contao 4.4.44: After downgrading the menu is put back to the normal (default) order. After uninstalling another module the order has changed again.

How to reproduce

  • Make fresh install of Contao 4.4.45
  • Log into contao backend and check order of modules underneath "Content"
  • Uninstall a module (e.g. FAQ) via Contao Manager
  • check the backend order again and "Events" should have moved to the 2nd position
@leofeyer
Copy link
Member

The order of back end menu items is not predictable. It depends on which extensions are installed, how the manager determines the loading order and how those extensions add menu items (prepend, inject, append).

@fritzmg
Copy link
Contributor

fritzmg commented Nov 13, 2019

The order of back end menu items is not predictable.

It should be in a vanilla Contao installation though.

@aschempp
Copy link
Member

The order of back end menu items is not predictable.

It should be in a vanilla Contao installation though.

It is, but he was adding and removing extensions, therefore affecting the vanilla-ness

@leofeyer leofeyer mentioned this issue Dec 16, 2019
Merged
leofeyer added a commit that referenced this issue Dec 16, 2019
@leofeyer
Do not use array_insert to inject modules and menu items (see #1100)
b712b65 
Description
-----------

Since the order of back end modules is no longer predictable (see #970), it does not make sense to use `array_insert()` to inject a menu item at a certain position. Most likely, it will not end up at this position anyway.

Commits
-------

e115cc0 Do not use array_insert to inject modules and menu items
7d30f38 Merge branch 'master' into bugfix/array-insert-menu
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aschempp @leofeyer @juju2 @fritzmg