Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Doctrine platform recognition #1010

Merged
merged 1 commit into from Nov 25, 2019
Merged

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Nov 22, 2019

The logic of the ParametersYamlPass needs to be run before the Plugin::addDefaultServerVersion() method, otherwise the DB connection always fails and our 'server_version' => '5.5' workaround will always be applied. This breaks the Doctrine platform recognition (see #979).

@leofeyer leofeyer added the bug label Nov 22, 2019
@leofeyer leofeyer added this to the 4.9 milestone Nov 22, 2019
@leofeyer leofeyer self-assigned this Nov 22, 2019
@aschempp
Copy link
Member

aschempp commented Nov 22, 2019

What if we don't add the server_version?

@Toflar
Copy link
Member

Toflar commented Nov 22, 2019

LGTM but why is that 4.9?

@leofeyer
Copy link
Member Author

What if we don't add the server_version=

Then we would have the problem described in contao/core-bundle#1422 again. 😉

LGTM but why is that 4.9?

Because the ParametersYamlPass (and support for env(DATABASE_URL)) has only been added in Contao 4.9.

@m-vo
Copy link
Member

m-vo commented Nov 22, 2019

But the referenced issue in #979 that this PR aims to fix occurs on Contao 4.8.5?

@leofeyer
Copy link
Member Author

leofeyer commented Nov 22, 2019

See #979 (comment)

@leofeyer leofeyer changed the title Move the ParametersYamlPass logic to the Plugin class Fix the Doctrine platform recognition Nov 25, 2019
@leofeyer leofeyer merged commit 1c1a157 into master Nov 25, 2019
@leofeyer leofeyer deleted the bugfix/server-version branch November 25, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants