Check the attribute type the BackendAccessVoter::supports() method #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Toflar The tests all seem to fail here because of the DebugClassLoader used in |
aschempp
previously approved these changes
Nov 26, 2019
|
@AndreasA Thank you for your pull request. Can you please rebase it onto the latest master branch? This should fix the CI issues. |
|
Rebased to latest master and now pipelines succeeded. |
leofeyer
approved these changes
Nov 27, 2019
leofeyer
changed the title
|
Thank you @AndreasA. |
leofeyer
changed the title
leofeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the e.g. ExpressionLanguage objects are ignored when checking for support in the BackendAccessVoter.
Fixes: contao/core-bundle#1710
See also previous PR (and the discussions) for core-bundle: contao/core-bundle#1711
Even if it is a bug in Symfony in the end, I think we should still add the check (at least until we have to update the Access Voter anyway to include the missing type hinting.