Automatically upgrade new password hashes #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytehead
previously approved these changes
Nov 27, 2019
leofeyer
approved these changes
Nov 27, 2019
|
Thank you @Toflar. |
Toflar
commented
Nov 27, 2019
| */ | ||
| public function upgradePassword(UserInterface $user, string $newEncodedPassword): void | ||
| { | ||
| if (!is_a($user, $this->userClass)) { |
There was a problem hiding this comment.
This shouldn't happen because of the supports() call. But anyway :)
There was a problem hiding this comment.
You are right. I have just copied the code from the refreshUser() method, but maybe it is unnecessary there as well?
contao/core-bundle/src/Security/User/ContaoUserProvider.php
Lines 87 to 91 in 1e08698
There was a problem hiding this comment.
Well, defensive programming - guess that's fine :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically upgrade bcrypt passwords to argon2 passwords when users log in (or whatever we will have in the future). Symfony FTW :)
Implements #538.