Add @internal to what is not covered by our BC promise #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
requested changes
Dec 3, 2019
There was a problem hiding this comment.
LGTM, found one issue in the comments.
Regarding your questions:
- What about controllers? Do they need an @internal tag, too?
I don't see why they would need to be extended. So yes.
- What about Contao\CoreBundle\Repository\RememberMeRepository?
I don't see why repositories would need to be extended. So yes.
- What about Contao\ManagerBundle\Api*?
- What about Contao\ManagerBundle\ContaoManager\ApiCommand*?
Imho the whole manager bundle is internal. What do you need to use or extend there?
leofeyer
force-pushed
the
feature/internal
branch
from
d4c1f3c
to
a8aaee0
Compare
Toflar
approved these changes
Dec 4, 2019
|
It seems no-one else was interested in reviewing, therefore I have merged this one now. 🤷♂ |
That's not really true, looks like two days was not enough time 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1031
TODO
@internaltag, too?Contao\CoreBundle\Repository\RememberMeRepository?Contao\ManagerBundle\Api\*?Contao\ManagerBundle\ContaoManager\ApiCommand\*?