Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we have the correct type when a search document is created #1102

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Make sure we have the correct type when a search document is created #1102

merged 2 commits into from
Dec 16, 2019

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Dec 16, 2019

According to the phpdoc comment, Response::getContent() may also return false.

@Toflar Toflar self-assigned this Dec 16, 2019
@Toflar Toflar added the bug label Dec 16, 2019
@Toflar Toflar added this to the 4.9 milestone Dec 16, 2019
@Toflar Toflar requested review from ausi and leofeyer December 16, 2019 14:50
@leofeyer leofeyer merged commit 3b79da4 into master Dec 16, 2019
@leofeyer leofeyer deleted the bugfix/fix-typehint branch December 16, 2019 17:41
@leofeyer
Copy link
Member

Thank you @Toflar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

@ausi ausi Awaiting requested review from ausi

Assignees

@Toflar Toflar

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Toflar @leofeyer