Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the service arguments more accurately #1115

Merged
merged 1 commit into from Dec 18, 2019
Merged

Test the service arguments more accurately #1115

merged 1 commit into from Dec 18, 2019

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Dec 18, 2019 •
edited

This also allows us to distinct between '@logger' and '@?logger'.

@leofeyer leofeyer added this to the 4.9 milestone Dec 18, 2019
@leofeyer leofeyer self-assigned this Dec 18, 2019
Toflar
Toflar approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leofeyer leofeyer merged commit c4bcb6d into master Dec 18, 2019
@leofeyer leofeyer deleted the bugfix/service-arguments branch December 18, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

@aschempp aschempp aschempp approved these changes

@ausi ausi Awaiting requested review from ausi

@bytehead bytehead Awaiting requested review from bytehead

Assignees

@leofeyer leofeyer

Labels
feature
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leofeyer @Toflar @aschempp