Fix compatibility with knplabs/knp-time-bundle 1.11.0 #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
approved these changes
Dec 31, 2019
bytehead
approved these changes
Dec 31, 2019
Toflar
approved these changes
Jan 3, 2020
aschempp
approved these changes
Jan 4, 2020
|
Thank you @ausi. |
|
Does that work with Symfony 4.2? Implementing an interface that does not exist? |
|
The contracts package has been documented for Symfony 4.2, so I guess it should work. Not 100% sure though. |
What do you mean by that? Which interface does not exist? |
leofeyer
added a commit
to contao/conflicts
that referenced
this pull request
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1136
After this gets merged and released we should revert contao/conflicts#9