Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the user and user group filters #1153

Merged
merged 1 commit into from Jan 3, 2020
Merged

Fix the user and user group filters #1153

merged 1 commit into from Jan 3, 2020

Conversation

@leofeyer
Copy link
Member

leofeyer commented Jan 3, 2020

No description provided.

@leofeyer leofeyer added the defect label Jan 3, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 3, 2020
@leofeyer leofeyer requested review from ausi, Toflar, bytehead and aschempp Jan 3, 2020
@leofeyer leofeyer self-assigned this Jan 3, 2020
Copy link
Member

Toflar left a comment

Can you explain these changes? I don‘t understand why it has to be removed from tl_user at first sight.

@leofeyer

This comment has been minimized.

Copy link
Member Author

leofeyer commented Jan 3, 2020

Yes, of course.

Users

The new fields from the ce_access extension have accidentally been added here.

Before

After

User groups

The new fields from the ce_access extension should have been added here.

Before

After

@Toflar
Toflar approved these changes Jan 3, 2020
Copy link
Member

Toflar left a comment

Perfect, thanks!

@leofeyer leofeyer merged commit fa552ce into master Jan 3, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.7% remains the same compared to 2aeda7f
Details
@leofeyer leofeyer deleted the hotfix/filter branch Jan 3, 2020
Tastaturberuf pushed a commit to Tastaturberuf/contao that referenced this pull request Jan 13, 2020
Description
-----------

-

Commits
-------

eca24ee Fix the user and user group filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.