Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the user and user group filters #1153

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix the user and user group filters #1153

merged 1 commit into from
Jan 3, 2020

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Jan 3, 2020

No description provided.

@leofeyer leofeyer added the bug label Jan 3, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 3, 2020
@leofeyer leofeyer self-assigned this Jan 3, 2020
Toflar
Toflar reviewed Jan 3, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain these changes? I don‘t understand why it has to be removed from tl_user at first sight.

@leofeyer
Copy link
Member Author

leofeyer commented Jan 3, 2020 •
edited
Loading

Yes, of course.

Users

The new fields from the ce_access extension have accidentally been added here.

Before

After

User groups

The new fields from the ce_access extension should have been added here.

Before

After

Toflar
Toflar approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@leofeyer leofeyer merged commit fa552ce into master Jan 3, 2020
@leofeyer leofeyer deleted the hotfix/filter branch January 3, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

@ausi ausi Awaiting requested review from ausi

@bytehead bytehead Awaiting requested review from bytehead

@aschempp aschempp Awaiting requested review from aschempp

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leofeyer @Toflar