Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the contao.image.sizes keys #1159

Merged
merged 2 commits into from Jan 8, 2020
Merged

Fix the contao.image.sizes keys #1159

merged 2 commits into from Jan 8, 2020

Conversation

@leofeyer
Copy link
Member

leofeyer commented Jan 7, 2020

Fixes #1081

@leofeyer leofeyer added the defect label Jan 7, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 7, 2020
@leofeyer leofeyer requested review from ausi, Toflar, bytehead and aschempp Jan 7, 2020
@leofeyer leofeyer self-assigned this Jan 7, 2020
@Toflar

This comment has been minimized.

Copy link
Member

Toflar commented Jan 7, 2020

Nice! Do you think we should have a general test that takes all possible configuration keys and checks them for [a-z_] so that this inconsistency doesn't happen again?

@leofeyer

This comment has been minimized.

Copy link
Member Author

leofeyer commented Jan 7, 2020

I do. Want me to add the test here or in a separate PR?

Copy link
Member

Toflar left a comment

Up to you, but I approve this one because it's correct as is imho.

@leofeyer

This comment has been minimized.

Copy link
Member Author

leofeyer commented Jan 7, 2020

Test added in 2d59f05.

@leofeyer leofeyer requested a review from Toflar Jan 7, 2020
@Toflar
Toflar approved these changes Jan 7, 2020
Copy link
Member

Toflar left a comment

Wonderful! I think this is going to help us in the future 👍

@ausi
ausi approved these changes Jan 7, 2020
@leofeyer leofeyer merged commit 10f7ea7 into master Jan 8, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.73% (+0.03%) compared to 03c84e7
Details
@leofeyer leofeyer deleted the bugfix/config-keys branch Jan 8, 2020
Tastaturberuf pushed a commit to Tastaturberuf/contao that referenced this pull request Jan 13, 2020
Description
-----------

Fixes contao#1081

Commits
-------

097bdac Fix the contao.image.sizes keys (see contao#1081)
2d59f05 Test that all configuration keys are snake_case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.