Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the contao.image.sizes keys #1159

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Fix the contao.image.sizes keys #1159

merged 2 commits into from
Jan 8, 2020

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Jan 7, 2020

Fixes #1081

@leofeyer leofeyer added the bug label Jan 7, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 7, 2020
@leofeyer leofeyer self-assigned this Jan 7, 2020
@leofeyer leofeyer mentioned this pull request Jan 7, 2020
Closed
@Toflar
Copy link
Member

Toflar commented Jan 7, 2020

Nice! Do you think we should have a general test that takes all possible configuration keys and checks them for [a-z_] so that this inconsistency doesn't happen again?

@leofeyer
Copy link
Member Author

leofeyer commented Jan 7, 2020

I do. Want me to add the test here or in a separate PR?

Toflar
Toflar previously approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you, but I approve this one because it's correct as is imho.

@leofeyer
Copy link
Member Author

leofeyer commented Jan 7, 2020

Test added in 2d59f05.

@leofeyer leofeyer requested a review from Toflar January 7, 2020 16:38
Toflar
Toflar approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! I think this is going to help us in the future 👍

@leofeyer leofeyer merged commit 10f7ea7 into master Jan 8, 2020
@leofeyer leofeyer deleted the bugfix/config-keys branch January 8, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@Toflar Toflar Toflar approved these changes

@bytehead bytehead bytehead approved these changes

@aschempp aschempp aschempp approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Unify the configuration style
5 participants
@leofeyer @Toflar @ausi @bytehead @aschempp