Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Escargot integration #1171

Merged
merged 9 commits into from Jan 13, 2020
Merged

Conversation

@Toflar
Copy link
Member

Toflar commented Jan 10, 2020

  • Updated to Escargot 0.5
  • Updated to webignition/robots-txt-file 3.0
  • Moved crawl related stuff from the Search to the Crawl namespace
@Toflar Toflar added the feature label Jan 10, 2020
@Toflar Toflar added this to the 4.9 milestone Jan 10, 2020
@Toflar Toflar requested a review from leofeyer Jan 10, 2020
@Toflar Toflar self-assigned this Jan 10, 2020
CS
@leofeyer leofeyer added defect and removed feature labels Jan 10, 2020
@leofeyer leofeyer changed the title Escargot integration cleanup Clean up the Escargot integration Jan 10, 2020
Copy link
Member

leofeyer left a comment

The PR is RTM to me, however, there is a dependency issue when installing the split bundles (see the CI checks):

There was 1 error:

1) Contao\CoreBundle\Tests\Command\CrawlCommandTest::testOptionsConfigureEscargotCorrectly
Error: Class 'Symfony\Bridge\Monolog\Handler\ConsoleHandler' not found

/home/runner/work/contao/contao/core-bundle/src/Command/CrawlCommand.php:169
/home/runner/work/contao/contao/core-bundle/src/Command/CrawlCommand.php:117
/home/runner/work/contao/contao/core-bundle/vendor/symfony/console/Command/Command.php:255
/home/runner/work/contao/contao/core-bundle/vendor/symfony/console/Tester/CommandTester.php:76
/home/runner/work/contao/contao/core-bundle/tests/Command/CrawlCommandTest.php:64
/home/runner/work/contao/contao/core-bundle/vendor/phpunit/phpunit/phpunit:61

Any idea what is causing this?

@Toflar

This comment has been minimized.

Copy link
Member Author

Toflar commented Jan 13, 2020

Ready @leofeyer

@leofeyer leofeyer merged commit 7ab6c72 into master Jan 13, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +10.26% compared to 0bb6227
Details
@leofeyer leofeyer deleted the bugfix/escargot-integration-cleanup branch Jan 13, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 13, 2020

Thank you @Toflar.

Tastaturberuf pushed a commit to Tastaturberuf/contao that referenced this pull request Jan 13, 2020
Description
-----------

* Updated to Escargot 0.5
* Updated to webignition/robots-txt-file 3.0
* Moved crawl related stuff from the `Search` to the `Crawl` namespace

Commits
-------

d78c974 Moved crawl related classes to correct namespace
35dfe1c Adjust to latest Escargot release
99124e1 Fixed missing default options that got lost during back end integration merge
f24f1be CS
1818099 Use CSV to log debug files
ca7dedc Fix the coding style
3b8204c Rename crawl_debug.log.csv to crawl_debug_log.csv
2799b03 Fix missing dep in core-bundle
298fbb0 Added missing unit tests for new CrawlCsvLogHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.