Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the Escargot integration #1171

Merged
merged 9 commits into from
Jan 13, 2020
Merged

Clean up the Escargot integration #1171

merged 9 commits into from
Jan 13, 2020

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Jan 10, 2020

  • Updated to Escargot 0.5
  • Updated to webignition/robots-txt-file 3.0
  • Moved crawl related stuff from the Search to the Crawl namespace

@Toflar Toflar added the feature label Jan 10, 2020
@Toflar Toflar added this to the 4.9 milestone Jan 10, 2020
@Toflar Toflar requested a review from leofeyer January 10, 2020 13:25
@Toflar Toflar self-assigned this Jan 10, 2020
@Toflar Toflar mentioned this pull request Jan 10, 2020
Closed
@leofeyer leofeyer added bug and removed feature labels Jan 10, 2020
@leofeyer leofeyer changed the title Escargot integration cleanup Clean up the Escargot integration Jan 10, 2020
leofeyer
leofeyer previously approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@leofeyer leofeyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is RTM to me, however, there is a dependency issue when installing the split bundles (see the CI checks):

There was 1 error:

1) Contao\CoreBundle\Tests\Command\CrawlCommandTest::testOptionsConfigureEscargotCorrectly
Error: Class 'Symfony\Bridge\Monolog\Handler\ConsoleHandler' not found

/home/runner/work/contao/contao/core-bundle/src/Command/CrawlCommand.php:169
/home/runner/work/contao/contao/core-bundle/src/Command/CrawlCommand.php:117
/home/runner/work/contao/contao/core-bundle/vendor/symfony/console/Command/Command.php:255
/home/runner/work/contao/contao/core-bundle/vendor/symfony/console/Tester/CommandTester.php:76
/home/runner/work/contao/contao/core-bundle/tests/Command/CrawlCommandTest.php:64
/home/runner/work/contao/contao/core-bundle/vendor/phpunit/phpunit/phpunit:61

Any idea what is causing this?

@Toflar
Copy link
Member Author

Toflar commented Jan 13, 2020

Ready @leofeyer

@Toflar Toflar mentioned this pull request Jan 13, 2020
Closed
@leofeyer leofeyer merged commit 7ab6c72 into master Jan 13, 2020
@leofeyer leofeyer deleted the bugfix/escargot-integration-cleanup branch January 13, 2020 10:17
@leofeyer
Copy link
Member

Thank you @Toflar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

Assignees

@Toflar Toflar

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Toflar @leofeyer