Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the MakeResponsePrivateListener for non-Contao requests #1176

Conversation

@Toflar
Copy link
Member

Toflar commented Jan 13, 2020

PR for #1079

I think it's better to disable it for all non-Contao requests. Not just the FE ones.

@Toflar Toflar requested review from aschempp and leofeyer Jan 13, 2020
@Toflar Toflar self-assigned this Jan 13, 2020
@Toflar Toflar added the defect label Jan 13, 2020
@Toflar Toflar added this to the 4.9 milestone Jan 13, 2020
@leofeyer leofeyer changed the title Disable MakeResponsePrivateListener for non-Contao requests Disable the MakeResponsePrivateListener for non-Contao requests Jan 13, 2020
@leofeyer leofeyer merged commit 133696a into master Jan 13, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.7% (+<.01%) compared to 7ab6c72
Details
@leofeyer leofeyer deleted the bugfix/disable-make-response-private-listener-for-non-contao-requests branch Jan 13, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 13, 2020

Thank you @Toflar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.