Do not decode entities in page names #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
reviewed
Jan 14, 2020
| @@ -210,7 +210,7 @@ protected function prepare($objPage) | |||
| } | |||
|
|
|||
| // Assign the title and description | |||
| $this->Template->title = StringUtil::stripInsertTags($this->replaceInsertTags($objLayout->titleTag)); // see #7097 | |||
| $this->Template->title = $this->replaceInsertTags($objLayout->titleTag); | |||
There was a problem hiding this comment.
I wonder if we should strip_tags() though? What if I'm using the {{br}} insert tag? Or whatever insert tag that generates HTML?
There was a problem hiding this comment.
We did not strip HTML tags before, but I guess it cannot hurt. Added in 31a2454.
aschempp
previously approved these changes
Jan 14, 2020
There was a problem hiding this comment.
The changes have been added in 2.6.3 (contao/core@28f57b7), unfortunately there's no note about why it was added.
I can already tell you there will be issues (like what @Toflar mentioned or the XML feed), but I think changing it is the correct approach and then we need to fix appearing issues in the long run.
|
I agree – even though the page title is never used in the XML sitemap. |
Toflar
approved these changes
Jan 14, 2020
aschempp
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473
Since insert tags are now removed recursively, we do not need the
StringUtil::stripInsertTags()call in thePageRegularclass anymore.