Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the correct error message if a wrong 2FA token is entered #1194

Merged
merged 1 commit into from Jan 16, 2020
Merged

Show the correct error message if a wrong 2FA token is entered #1194

merged 1 commit into from Jan 16, 2020

Conversation

bytehead
Copy link
Member

This fixes #1186.

@bytehead bytehead self-assigned this Jan 15, 2020
@bytehead bytehead added the bug label Jan 15, 2020
@bytehead bytehead added this to the 4.9 milestone Jan 15, 2020
@Toflar Toflar requested a review from aschempp January 15, 2020 19:16
Toflar
Toflar approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks logical to me :)

aschempp
aschempp approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was the reason I did re-throw the original exception, but then the log message was wrong 😂

@leofeyer leofeyer changed the title Fix wrong exception Show the correct error message if a wrong 2FA token is entered Jan 16, 2020
@leofeyer leofeyer merged commit 9651209 into contao:master Jan 16, 2020
@leofeyer
Copy link
Member

Thank you @bytehead.

@bytehead bytehead deleted the bugfix/wrong-error-message-on-2fa branch January 16, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

@aschempp aschempp aschempp approved these changes

@leofeyer leofeyer Awaiting requested review from leofeyer

Assignees

@bytehead bytehead

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Wrong error message if the 2FA token is invalid
4 participants
@bytehead @leofeyer @Toflar @aschempp