Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all form actions #1201

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Remove all form actions #1201

merged 2 commits into from
Jan 17, 2020

Conversation

aschempp
Copy link
Member

fixes #1170

@aschempp aschempp added the bug label Jan 16, 2020
@aschempp aschempp self-assigned this Jan 16, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 16, 2020
ausi
ausi previously approved these changes Jan 16, 2020
View reviewed changes
@leofeyer leofeyer mentioned this pull request Jan 16, 2020
Closed
leofeyer
leofeyer requested changes Jan 16, 2020
View reviewed changes
Copy link
Member

@leofeyer leofeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have found two left-over occurrences:

contao/newsletter-bundle/src/Resources/contao/classes/Newsletter.php

Line 540 in abae57a

<form action="' . ampersand(Environment::get('request')) . '" id="tl_recipients_import" class="tl_form tl_edit_form" method="post" enctype="multipart/form-data">

contao/core-bundle/src/Resources/views/Frontend/preview_toolbar_base.html.twig

Line 5 in abae57a

<form action="{{ action }}" method="post">

@aschempp
Copy link
Member Author

aschempp commented Jan 17, 2020 •
edited
Loading

Newsletter.php is adjusted. The action in the preview toolbar twig needs to remain, it does not post to the current URL but the preview endpoint.

@leofeyer leofeyer merged commit 9c0502b into master Jan 17, 2020
@leofeyer leofeyer deleted the bugfix/empty-action branch January 17, 2020 07:49
@leofeyer
Copy link
Member

Thank you @aschempp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

@ausi ausi ausi left review comments

@Toflar Toflar Awaiting requested review from Toflar

Assignees

@aschempp aschempp

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Remove form action
3 participants
@aschempp @leofeyer @ausi