Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the clickable area of the fieldset legends #1203

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

leofeyer
Copy link
Member

The green area is clickable.

Before

After

@leofeyer leofeyer added the bug label Jan 17, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 17, 2020
@leofeyer leofeyer self-assigned this Jan 17, 2020
@leofeyer leofeyer merged commit 35f517e into master Jan 17, 2020
@leofeyer leofeyer deleted the bugfix/clickable-legend branch January 17, 2020 07:49
@asaage
Copy link

asaage commented Jan 17, 2020

Honestly i don't get it.
Is this a follow-up to #1177 ?
I'm fine with the top/bottom padding-adjustment BUT:

In C4 the width (and clickable area) of dca-legends has allways been 100%

image

They work like an ordinary accordion where (i think) it's a common pattern to toggle in the whitespace.
I don't see any reason why they should be shortened to the text-length.

That would be like:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants