Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the DB password to null if empty #1237

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Set the DB password to null if empty #1237

merged 1 commit into from
Jan 23, 2020

Conversation

leofeyer
Copy link
Member

Right now the DB password is stored as empty string if left blank. Storing null is more explicit, although both variants work.

@leofeyer leofeyer added the bug label Jan 22, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 22, 2020
@leofeyer leofeyer requested a review from a team January 22, 2020 21:35
@leofeyer leofeyer self-assigned this Jan 22, 2020
Toflar
Toflar reviewed Jan 22, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default return value of $request->request->get() is already null if it doesn‘t exist?

@leofeyer
Copy link
Member Author

The field exists and returns an empty string. However, we want to store null instead.

Toflar
Toflar approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@leofeyer leofeyer merged commit 087f7a5 into 4.9 Jan 23, 2020
@leofeyer leofeyer deleted the bugfix/db-password branch January 23, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leofeyer @Toflar