Correctly publish new folders

[leofeyer]

Fixes #1208

[aschempp]

How does that code make a difference?

[leofeyer]

This is what happened:

$count = 0;
$strName = basename($strPath);

if (($strNewPath = str_replace($strName, Contao\Input::post('name'), $strPath, $count)) && $count > 0 && is_dir($rootDir . '/' . $strNewPath))

Then the code inspector said "$count > 0 costs less than the previous condition, so we switched to:

$count = 0;
$strName = basename($strPath);

if ($count > 0 && ($strNewPath = str_replace($strName, Contao\Input::post('name'), $strPath, $count)) && is_dir($rootDir . '/' . $strNewPath))

And then the if branch was no longer executed. 🤷‍♂

Now we are back at what we had before, only $strNewPath is declared before the if condition to not confuse the code inspector.

$count = 0;
$strName = basename($strPath);
$strNewPath = str_replace($strName, Contao\Input::post('name'), $strPath, $count);

if ($strNewPath && $count > 0 && is_dir($rootDir . '/' . $strNewPath))

[aschempp]

I see. Because $count is set by the str_replace call.