Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the front end preview URLs in the back end #1286

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Fix the front end preview URLs in the back end #1286

merged 2 commits into from
Feb 7, 2020

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Feb 4, 2020

Fixes #1224

@leofeyer leofeyer added the bug label Feb 4, 2020
@leofeyer leofeyer added this to the 4.9 milestone Feb 4, 2020
@leofeyer leofeyer requested a review from a team February 4, 2020 16:00
@leofeyer leofeyer self-assigned this Feb 4, 2020
@leofeyer leofeyer mentioned this pull request Feb 4, 2020
Closed
@aschempp aschempp linked an issue Feb 7, 2020 that may be closed by this pull request
FE preview redirect for pages inconsistent #1224
Closed
bytehead
bytehead previously approved these changes Feb 7, 2020
View reviewed changes
Toflar
Toflar requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the missing test for the article handling.

@leofeyer
Copy link
Member Author

leofeyer commented Feb 7, 2020

Unit test added in 7dfad9c.

Toflar
Toflar approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leofeyer leofeyer merged commit c540367 into 4.9 Feb 7, 2020
@leofeyer leofeyer deleted the bugfix/preview-urls branch February 7, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi left review comments

@aschempp aschempp aschempp left review comments

@richardhj richardhj richardhj left review comments

@Toflar Toflar Toflar approved these changes

@bytehead bytehead bytehead approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

FE preview redirect for pages inconsistent
6 participants
@leofeyer @ausi @Toflar @bytehead @aschempp @richardhj