Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the front end preview URLs in the back end #1286

Merged
merged 2 commits into from Feb 7, 2020
Merged

Conversation

@leofeyer
Copy link
Member

leofeyer commented Feb 4, 2020

Fixes #1224

@leofeyer leofeyer added the defect label Feb 4, 2020
@leofeyer leofeyer added this to the 4.9 milestone Feb 4, 2020
@leofeyer leofeyer requested a review from contao/reviewers Feb 4, 2020
@leofeyer leofeyer self-assigned this Feb 4, 2020
@aschempp aschempp linked an issue that may be closed by this pull request Feb 7, 2020
Copy link
Member

Toflar left a comment

LGTM apart from the missing test for the article handling.

@leofeyer

This comment has been minimized.

Copy link
Member Author

leofeyer commented Feb 7, 2020

Unit test added in 7dfad9c.

@Toflar
Toflar approved these changes Feb 7, 2020
Copy link
Member

Toflar left a comment

👍

@leofeyer leofeyer merged commit c540367 into 4.9 Feb 7, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 90.12% (+0.23%) compared to 13e3da9
Details
@leofeyer leofeyer deleted the bugfix/preview-urls branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.