Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the post update/install CLI hint #1289

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Feb 5, 2020

No description provided.

@Toflar Toflar added this to the 4.9 milestone Feb 5, 2020
@Toflar Toflar self-assigned this Feb 5, 2020
@Toflar Toflar added the bug label Feb 5, 2020
@aschempp
Copy link
Member

aschempp commented Feb 7, 2020

I wonder if there's a reason not to automatically run contao:migrate for a Contao Managed Edition after installing packages?

@leofeyer leofeyer merged commit fcfa1ed into 4.9 Feb 7, 2020
@leofeyer leofeyer deleted the fix-cli-post-update-install-hint branch February 7, 2020 09:01
@leofeyer
Copy link
Member

leofeyer commented Feb 7, 2020

Thank you @Toflar.

@leofeyer
Copy link
Member

leofeyer commented Feb 7, 2020

I wonder if there's a reason not to automatically run contao:migrate for a Contao Managed Edition after installing packages?

@aschempp IDK. Maybe we should create a new issue and label it "up for discussion"?

@Toflar
Copy link
Member Author

Toflar commented Feb 7, 2020

I don't think that makes sense, I would personally never want that because I want to see what actually changes. Migrations should never happen without having somebody to look over the changes.

@aschempp
Copy link
Member

aschempp commented Feb 7, 2020

Migrations should never happen without having somebody to look over the changes.

But that's not how it currently works. If you open the install tool, all runonce.php files are executed automatically. The install tool offers to run each query individually, but most of the cases you simply run all of them. Maybe keep some drop culumns, but you always need to add stuff.

I agree it might not be wanted in a local environment, where you possibly don't have a database, or you want to check the migrations first. But a managed edition on a webserver probably always should run time …

@Toflar
Copy link
Member Author

Toflar commented Feb 7, 2020

But that's not how it currently works.

Yeah, and the way it currently works is bad 😄

@leofeyer leofeyer changed the title Improve post update or install CLI hint Improve the post update/install CLI hint Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants