Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the member widget if searching protected sites is disabled #1291

Merged
merged 1 commit into from Feb 7, 2020

Conversation

@leofeyer
Copy link
Member

leofeyer commented Feb 7, 2020

Fixes #1280

@contao/developers Should we disable indexing protected pages by default?

@leofeyer leofeyer added the defect label Feb 7, 2020
@leofeyer leofeyer added this to the 4.9 milestone Feb 7, 2020
@leofeyer leofeyer requested a review from contao/reviewers Feb 7, 2020
@leofeyer leofeyer self-assigned this Feb 7, 2020
@Toflar
Toflar approved these changes Feb 7, 2020
@fritzmg

This comment has been minimized.

Copy link
Collaborator

fritzmg commented Feb 7, 2020

@contao/developers Should we disable indexing protected pages by default?

Isn't it already? At least that's how it used to be.

@Toflar

This comment has been minimized.

Copy link
Member

Toflar commented Feb 7, 2020

@contao/developers Should we disable indexing protected pages by default?

It is disabled by default.

@leofeyer

This comment has been minimized.

Copy link
Member Author

leofeyer commented Feb 7, 2020

I see. Sorry 🙄

@leofeyer leofeyer merged commit 8b94dba into 4.9 Feb 7, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 90.12% (+0.00%) compared to c540367
Details
@leofeyer leofeyer deleted the bugfix/crawler-member-widget branch Feb 7, 2020
@aschempp

This comment has been minimized.

Copy link
Contributor

aschempp commented Feb 7, 2020

Shouldn't we show a hint if indexing protected pages is disabled?

@Toflar

This comment has been minimized.

Copy link
Member

Toflar commented Feb 7, 2020

I don't think we should. There are so many configuration options, we'd need loads of hints everywhere to tell the users what they could enable. That's just something that belongs into the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.