-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle removed search indexers #1295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
commented
Feb 7, 2020
Toflar
force-pushed
the
bugfix/handle-removed-search-indexers
branch
from
February 7, 2020 13:32
65f6835
to
f75ed42
Compare
Added unit tests. This is RTM. If you also remove the broken link checker, the crawler is now gone in the back end as is the |
ausi
previously approved these changes
Feb 8, 2020
leofeyer
requested changes
Feb 11, 2020
leofeyer
requested changes
Feb 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one test method name, this PR is RTM IMHO.
core-bundle/tests/DependencyInjection/Compiler/CrawlerPassTest.php
Outdated
Show resolved
Hide resolved
….php Co-Authored-By: Leo Feyer <github@contao.org>
leofeyer
approved these changes
Feb 13, 2020
Thank you @Toflar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1252