Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle removed search indexers #1295

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Feb 7, 2020

Fixes #1252

@Toflar Toflar added the bug label Feb 7, 2020
@Toflar Toflar added this to the 4.9 milestone Feb 7, 2020
@Toflar Toflar self-assigned this Feb 7, 2020
@Toflar Toflar linked an issue Feb 7, 2020 that may be closed by this pull request
@Toflar Toflar force-pushed the bugfix/handle-removed-search-indexers branch from 65f6835 to f75ed42 Compare February 7, 2020 13:32
@Toflar Toflar requested review from ausi and leofeyer and removed request for ausi February 7, 2020 13:32
@Toflar
Copy link
Member Author

Toflar commented Feb 7, 2020

Added unit tests. This is RTM. If you also remove the broken link checker, the crawler is now gone in the back end as is the contao:crawl command.

ausi
ausi previously approved these changes Feb 8, 2020
Copy link
Member

@leofeyer leofeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one test method name, this PR is RTM IMHO.

….php

Co-Authored-By: Leo Feyer <github@contao.org>
@leofeyer leofeyer merged commit a5feefc into 4.9 Feb 13, 2020
@leofeyer leofeyer deleted the bugfix/handle-removed-search-indexers branch February 13, 2020 13:42
@leofeyer
Copy link
Member

Thank you @Toflar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-existent service error if search is disabled
3 participants