Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several trusted device issues #1299

Merged
merged 8 commits into from Feb 14, 2020
Merged

Fix several trusted device issues #1299

merged 8 commits into from Feb 14, 2020

Conversation

@bytehead
Copy link
Member

bytehead commented Feb 7, 2020

Here's a proposal how to fix #1285.

@bytehead bytehead self-assigned this Feb 7, 2020
@bytehead bytehead added the defect label Feb 7, 2020
@bytehead bytehead added this to the 4.9 milestone Feb 7, 2020
@bytehead bytehead requested review from leofeyer and aschempp Feb 7, 2020
bytehead added 3 commits Feb 7, 2020
Copy link
Contributor

aschempp left a comment

generally looks good. Is there a reason to store the version in the database at all? I don't think we ever use it?

@bytehead

This comment has been minimized.

Copy link
Member Author

bytehead commented Feb 7, 2020

Is there a reason to store the version in the database at all? I don't think we ever use it?

Thats true, missed that!

bytehead added 2 commits Feb 7, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 11, 2020

Besides the two open questions, this PR looks good to me. 👍

@bytehead bytehead requested a review from aschempp Feb 13, 2020
@leofeyer leofeyer changed the title [RFC] Removes current device and fixes other issues related to trusted devices Fix several trusted device issues Feb 13, 2020
@leofeyer leofeyer merged commit b3cc15a into contao:4.9 Feb 14, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 90.4% (+0.27%) compared to c540367
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 14, 2020

Thank you @bytehead.

@bytehead bytehead deleted the bytehead:bugfix/1285 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.