Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several trusted device issues #1299

Merged
merged 8 commits into from
Feb 14, 2020
Merged

Fix several trusted device issues #1299

merged 8 commits into from
Feb 14, 2020

Conversation

bytehead
Copy link
Member

@bytehead bytehead commented Feb 7, 2020

Here's a proposal how to fix #1285.

@bytehead bytehead self-assigned this Feb 7, 2020
@bytehead bytehead added the bug label Feb 7, 2020
@bytehead bytehead added this to the 4.9 milestone Feb 7, 2020
aschempp
aschempp reviewed Feb 7, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good. Is there a reason to store the version in the database at all? I don't think we ever use it?

manager-bundle/src/Resources/skeleton/config/config.yml Outdated Show resolved Hide resolved
@bytehead
Copy link
Member Author

bytehead commented Feb 7, 2020

Is there a reason to store the version in the database at all? I don't think we ever use it?

Thats true, missed that!

@leofeyer
Copy link
Member

Besides the two open questions, this PR looks good to me. 👍

@leofeyer leofeyer linked an issue Feb 11, 2020 that may be closed by this pull request
"Current Device" for Trusted Devices does not work #1285
Closed
@leofeyer leofeyer mentioned this pull request Feb 11, 2020
Closed
@bytehead bytehead mentioned this pull request Feb 11, 2020
Merged
@leofeyer leofeyer added up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. and removed up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. labels Feb 13, 2020
@leofeyer leofeyer changed the title [RFC] Removes current device and fixes other issues related to trusted devices Fix several trusted device issues Feb 13, 2020
@leofeyer leofeyer merged commit b3cc15a into contao:4.9 Feb 14, 2020
@leofeyer
Copy link
Member

Thank you @bytehead.

@bytehead bytehead deleted the bugfix/1285 branch February 14, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

@aschempp aschempp Awaiting requested review from aschempp

Assignees

@bytehead bytehead

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

"Current Device" for Trusted Devices does not work
3 participants
@bytehead @leofeyer @aschempp