Clear the dev cache in the script handler

[Toflar]

Fixes #1361

[fritzmg]

Aren't these commands executed in the current environment anyway? Thus, if you do

static::executeCommand('cache:clear --no-warmup', $event);
static::executeCommand('cache:clear --no-warmup --env=dev', $event);

and you configured the APP_ENV to be dev currently, the production cache will not actually get deleted, since it clears the dev cache both times.

[Toflar]

Correct. That's your mistake then, isn't it?

[fritzmg]

Not sure what you mean. This change is supposed to fix an issue that occurs, if you switch the environment, after a composer update/install for example. I am just showing, that this would only fix it, if you go from prod to dev, but not from dev to prod.

[ausi]

@fritzmg you mean we should use something like this?

static::executeCommand('cache:clear --no-warmup --env=prod', $event);
static::executeCommand('cache:clear --no-warmup --env=dev', $event);

[fritzmg]

Possibly. @Tastaturberuf mentioned in #1357, that apparently the Script Handler will always use prod. Haven't confirmed this myself yet.

[aschempp]

if we wanna clear both environments, then adding --env=prod to the first call would certainly be correct.

[Toflar]

I actually found the issue. We were using getenv('APP_ENV') which only works with real environment variables because at the time the script handler is executed, no .env file is handled.
We have to be explicit about our environments, I think it's correct now.

[fritzmg]

Shouldn't this be changed in Contao 4.4 as well?

[leofeyer]

Thank you @Toflar.

[fritzmg]

For some reason this is not working:

Contents of var/cache/dev after a request to the back end for example has been made, with APP_ENV=dev:

annotations.map
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.php
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.php.meta
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.preload.php
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.xml
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.xml.meta
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainerCompiler.log
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainerDeprecations.log
ContainerDBMJOYw
ContainerYxAQez3
ContainerYxAQez3.legacy
doctrine
pools
profiler
twig
UrlGenerator.php
UrlGenerator.php.meta
UrlMatcher.php
UrlMatcher.php.meta

composer install output (excerpt):

> Contao\ManagerBundle\Composer\ScriptHandler::initializeApplication
Added the web/app.php file.
Added the web/index.php file.
Added the web/preview.php file.

 // Clearing the cache for the prod environment with debug false


 [OK] Cache for the "prod" environment (debug=false) was successfully cleared.



 // Clearing the cache for the dev environment with debug true


 [OK] Cache for the "dev" environment (debug=true) was successfully cleared.



 // Warming up the cache for the prod environment with debug false


 [OK] Cache for the "prod" environment (debug=false) was successfully warmed.



 Trying to install assets as relative symbolic links.

Contents of var/cache/dev after composer install:

annotations.map
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.php
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.php.meta
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.preload.php
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.xml
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainer.xml.meta
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainerCompiler.log
appContao_ManagerBundle_HttpKernel_ContaoKernelDevDebugContainerDeprecations.log
ContainerDBMJOYw
ContainerYxAQez3
ContainerYxAQez3.legacy
doctrine
pools
profiler
twig
UrlGenerator.php
UrlGenerator.php.meta
UrlMatcher.php
UrlMatcher.php.meta

Contents of var/cache/dev after cache:clear --no-warmup --env=dev:

ContainerDBMJOYw
ContainerDBMJOYw.legacy

I noticed this after installing an extension, while having APP_ENV=dev in my .env. Once installed, no services, routes or templates of that package where available. I had to manually clear the dev cache, even though it was supposed to be cleared during the composer process.