Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a context prefix in the JSON-LD schema #1457

Merged
merged 4 commits into from Mar 2, 2020

Conversation

@ausi
Copy link
Member

ausi commented Mar 2, 2020

As discussed in #1236 (comment)

@ausi ausi added the defect label Mar 2, 2020
@ausi ausi added this to the 4.9 milestone Mar 2, 2020
@ausi ausi self-assigned this Mar 2, 2020
@ausi ausi requested a review from contao/reviewers Mar 2, 2020
@leofeyer leofeyer linked an issue that may be closed by this pull request Mar 2, 2020
leofeyer added 3 commits Mar 2, 2020
# Conflicts:
#	core-bundle/src/Resources/contao/pages/PageRegular.php
@Toflar
Toflar approved these changes Mar 2, 2020
@leofeyer leofeyer merged commit 19ff24f into contao:4.9 Mar 2, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 90.32% (+0.03%) compared to 0059dd4
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Mar 2, 2020

Thank you @ausi.

leofeyer added a commit that referenced this pull request Mar 6, 2020
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | -
| Docs PR or issue | -

After adding the context prefixes to the JSON-LD keys in #1457, we did not adjust the HTML markup in the `DefaultIndexerTest` class. Unfortunately, the unit tests now fail.

Commits
-------

ae96975 Adjust the JSON-LD data in the default indexer test
3bebb6b Fix JSON LD parsing
issue-bot pushed a commit that referenced this pull request Mar 6, 2020
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | -
| Docs PR or issue | -

After adding the context prefixes to the JSON-LD keys in #1457, we did not adjust the HTML markup in the `DefaultIndexerTest` class. Unfortunately, the unit tests now fail.

Commits
-------

ae96975 Adjust the JSON-LD data in the default indexer test
3bebb6b Fix JSON LD parsing
@leofeyer leofeyer changed the title Use context prefix for json-ld schema Use a context prefix in the JSON-LD schema Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.