Use a context prefix in the JSON-LD schema #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core-bundle/src/Resources/contao/pages/PageRegular.php
leofeyer
approved these changes
Mar 2, 2020
Toflar
approved these changes
Mar 2, 2020
|
Thank you @ausi. |
leofeyer
added a commit
that referenced
this pull request
Mar 6, 2020
Description ----------- | Q | A | -----------------| --- | Fixed issues | - | Docs PR or issue | - After adding the context prefixes to the JSON-LD keys in #1457, we did not adjust the HTML markup in the `DefaultIndexerTest` class. Unfortunately, the unit tests now fail. Commits ------- ae96975 Adjust the JSON-LD data in the default indexer test 3bebb6b Fix JSON LD parsing
ghost
pushed a commit
that referenced
this pull request
Mar 6, 2020
Description ----------- | Q | A | -----------------| --- | Fixed issues | - | Docs PR or issue | - After adding the context prefixes to the JSON-LD keys in #1457, we did not adjust the HTML markup in the `DefaultIndexerTest` class. Unfortunately, the unit tests now fail. Commits ------- ae96975 Adjust the JSON-LD data in the default indexer test 3bebb6b Fix JSON LD parsing
leofeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1236 (comment)