Remove string type hint as there can be an array value

[bytehead]

Q	A
Fixed issues	n/a
Docs PR or issue	n/a

Recently this error showed up (via sentry.io) multiple times in a Contao 4.9.1 setup:

TypeError
Argument 2 passed to Contao\CoreBundle\EventListener\CsrfTokenCookieSubscriber::isCsrfCookie() must be of the type string, array given, called in /vendor/contao/core-bundle/src/EventListener/CsrfTokenCookieSubscriber.php on line 168

I'm afraid I don't have a case to reproduce this behaviour on my local machine.

But the method itself checks if it is a string or not:

contao/core-bundle/src/EventListener/CsrfTokenCookieSubscriber.php

Lines 178 to 180 in 3f24a79

	if (!\is_string($key)) {
	return false;
	}

Looks like we can remove the type hint of the second argument.

[aschempp]

I'd love to know where the error comes from? Wouldn't it be better to keep the type hint and remove the is_string check?

[bytehead]

I don't know. Is it possible, that the $value here

contao/core-bundle/src/EventListener/CsrfTokenCookieSubscriber.php

Lines 90 to 94 in 3f24a79

	foreach ($request->cookies as $key => $value) {
	if (!$this->isCsrfCookie($key, $value)) {
	return true;
	}
	}

is an array?

[fritzmg]

I think Symfony automatically deserializes serialized cookie data.

[leofeyer]

$request->cookies basically maps $_COOKIES, therefore the value can be anything. It seems correct to me to remove the type hint in this case, which implicitly sets the type to mixed.

[leofeyer]

Thank you @bytehead.