Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the picker in the meta wizard #1592

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Fix the picker in the meta wizard #1592

merged 3 commits into from
Mar 30, 2020

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Mar 30, 2020 •
edited
Loading

Q A
Fixed issues Fixes #1403
Docs PR or issue -

Use a static row count in the meta wizard so the link picker works in "edit multiple" mode and there are no duplicate ID attributes such as link_0.

@leofeyer leofeyer added the bug label Mar 30, 2020
@leofeyer leofeyer added this to the 4.9 milestone Mar 30, 2020
@leofeyer leofeyer requested a review from a team March 30, 2020 09:51
@leofeyer leofeyer self-assigned this Mar 30, 2020
@leofeyer leofeyer changed the title Use a static row count in the meta wizard so it works in "edit multiple" mode Use a static row count in the meta wizard Mar 30, 2020
@leofeyer leofeyer linked an issue Mar 30, 2020 that may be closed by this pull request
Link-Picker in Dateiverwaltung mit "mehrere bearbeiten" defekt #1403
Closed
aschempp
aschempp reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the field name be unique in edit-all mode already? maybe we should have used $this->strId instead of $field (not sure about the exact name)?

@leofeyer
Copy link
Member Author

You are right. Changed in 7e61aa8.

@leofeyer leofeyer requested a review from aschempp March 30, 2020 14:43
Toflar
Toflar previously approved these changes Mar 30, 2020
View reviewed changes
aschempp
aschempp reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does $this->strId not contain ctrl_?

@leofeyer
Copy link
Member Author

Nope. ctrl_ is prefixed as string in the markup.

@leofeyer leofeyer changed the title Use a static row count in the meta wizard Fix the picker in the meta wizard Mar 30, 2020
@leofeyer leofeyer merged commit e0f5014 into contao:4.9 Mar 30, 2020
@leofeyer leofeyer deleted the fix/meta-link-picker branch March 30, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp approved these changes

@Toflar Toflar Toflar left review comments

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Link-Picker in Dateiverwaltung mit "mehrere bearbeiten" defekt
3 participants
@leofeyer @Toflar @aschempp