Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixed position of toolbar elements #1711

Merged
merged 1 commit into from
May 8, 2020

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented May 8, 2020

Q A
Fixed issues N/A
Docs PR or issue N/A

Currently, the toolbar and button look a bit off, if you have a margin on the body, e.g. in a testing environment with no CSS (where the browser's default body margin applies).

Annotation 2020-05-08 093738-3

Annotation 2020-05-08 093738-4

This is fixed by adding the missing position directives:

Annotation 2020-05-08 093654

Annotation 2020-05-08 093654-2

@fritzmg fritzmg changed the title fix fixed position of toolbar elements Fix fixed position of toolbar elements May 8, 2020
@leofeyer leofeyer added the bug label May 8, 2020
@leofeyer leofeyer added this to the 4.9 milestone May 8, 2020
@leofeyer leofeyer merged commit 59eacb2 into contao:4.9 May 8, 2020
@leofeyer
Copy link
Member

leofeyer commented May 8, 2020

Thank you @fritzmg.

@fritzmg fritzmg deleted the improve-preview-toolbar branch May 8, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants