Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notices for empty database result sets #1742

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix notices for empty database result sets #1742

merged 2 commits into from
May 14, 2020

Conversation

ausi
Copy link
Member

@ausi ausi commented May 13, 2020

Q A
Fixed issues Fixes #1739

Same as #1741 for the 4.9 branch

@ausi ausi added the bug label May 13, 2020
@ausi ausi added this to the 4.9 milestone May 13, 2020
@ausi ausi requested a review from a team May 13, 2020 19:51
@ausi ausi self-assigned this May 13, 2020
@ausi ausi changed the title Fix unexpected undefined offset notices [4.9] Fix notices for empty database result sets May 13, 2020
leofeyer
leofeyer previously approved these changes May 14, 2020
View reviewed changes
@leofeyer leofeyer changed the title [4.9] Fix notices for empty database result sets Fix notices for empty database result sets May 14, 2020
@leofeyer
Copy link
Member

There is a PHPStan error though that needs to be fixed.

@leofeyer leofeyer merged commit 41d60cc into contao:4.9 May 14, 2020
@leofeyer
Copy link
Member

Thank you @ausi.

@leofeyer leofeyer mentioned this pull request May 14, 2020
Closed
@ausi ausi deleted the fix/empty-database-result-4-9 branch December 3, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

Assignees

@ausi ausi

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ausi @leofeyer