-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Osano Cookie Consent cookie to the cookie deny list #1763
Conversation
Shouldn't we rather find a general solution how to manually add more cookies to the blacklist? Otherwise, everyone will soon have the idea to push their tool into the Contao repository. |
You can already define your own white list. See https://docs.contao.org/dev/reference/config/#environment-variables-for-the-contao-managed-edition |
Also the Osano Cookieconsent script should switch to |
Osano Cookie Consent is not just any tool, it is one of the most popular, according to their own statement the most popular. |
The idea of the blacklist is to increase the possibility of cache hits without forcing every single Contao user to deep-dive into the topic of caching. We just want to generate good results by default. |
I fully agree with @Toflar. We should try to add as many commonly used tools as possible to the blacklist, so Contao works nicely with them out of the box. |
Thank you @Mynyx. |
Add the cookie
cookieconsent_status
of Osano Cookie Consent to the cookie blacklist.See https://github.com/osano/cookieconsent/blob/0817f677a412bfef7edb6e26901377b0a3a193c2/src/options/popup.js#L15