Fix Escargot 0.6 compat and skip broken link checker #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests unrelated 🤷♂️ |
|
Can we may be shorten the tag to |
Fixed. |
I would like to keep the name consistent with the name of the subscriber if you don't mind :) |
Toflar
force-pushed
the
fix/escargot-06-compat-and-skip-broken-link-checker
branch
from
14d4746
to
fb0e836
Compare
bytehead
previously approved these changes
Jun 3, 2020
|
I've taken advantage of this PR to also add timing information to the debug log which is imho a bug too (a log without time information isn't a super useful log at times ;)). |
leofeyer
approved these changes
Jun 9, 2020
|
Thank you @Toflar. |
leofeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed compat with Escargot 0.6 which also automatically adds tags for
dataattributes found on links.There have been reports in the forums that users have links that the broken link checker doesn't need to check because it will take forever and it's actually irrelevant.
That's possible using these changes by turning your
<a href="foobar">link</a>into<a href="foobar" data-skip-broken-link-checker>link</a>.