Improve the performance of the file manager #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is at least one result so we can early abort
fritzmg
previously approved these changes
Jun 16, 2020
ausi
previously approved these changes
Jun 16, 2020
|
That's great! 🎉 Can you rebase your changes onto the |
Toflar
dismissed stale reviews from ausi and fritzmg
The base branch was changed.
|
I branched correctly but picked the wrong target branch :) |
bytehead
approved these changes
Jun 16, 2020
aschempp
approved these changes
Jun 16, 2020
ausi
approved these changes
Jun 16, 2020
|
Thank you @Toflar. |
leofeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a huge performance bottleneck in the file manager.
To check for permissions, we count all the files for every single delete button callback recursively. However, we only need to know if there is at least something so the actual number is completely irrelevant to us and we can early return.
Saved 2 seconds of loading time for my use case :)