Fix the back end layout yet again #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
reviewed
Jun 29, 2020
|
Also, we can remove the search field padding workaround for Firefox again: https://github.com/contao/contao/pull/1875/files#diff-6d58d2e9400bef23b3f9ae54a41f666bR306-R309 |
leofeyer
approved these changes
Jun 29, 2020
|
Thank you @fritzmg. |
leofeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1823, #1875 and #1877
Some previous changes have been reverted, some new changes have been added.
w50widget combinations in any browser, zoom level and dppx combination that I have tested (tested with newest Firefox, Chrome and Edge).@leofeyer can you test these changes in Safari too please? Hopefully this is now fixed for good and we don't have to touch it again, until we re-do the whole thing with CSS grids 馃榿
If everything checks out, I'll update the PR for Contao 4.4 accordingly.