Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the $rootDir changes in the ContaoModuleBundle class #1894

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Revert the $rootDir changes in the ContaoModuleBundle class #1894

merged 1 commit into from
Jul 8, 2020

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Jul 2, 2020

As discussed in Mumble on July 2nd, this needs to be reverted for Contao 4.9 and re-applied in Contao 4.10.

@leofeyer leofeyer added the bug label Jul 2, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jul 2, 2020
@leofeyer leofeyer self-assigned this Jul 2, 2020
@leofeyer leofeyer requested a review from aschempp July 2, 2020 14:10
aschempp
aschempp requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also revert the unit tests

@leofeyer
Copy link
Member Author

leofeyer commented Jul 3, 2020

What exactly do you mean? The ContaoModuleBundleTest class has not been changed in your original PR.

@leofeyer leofeyer merged commit 57d288e into 4.9 Jul 8, 2020
@leofeyer leofeyer deleted the fix/contao-module-bundle branch July 8, 2020 14:52
@leofeyer leofeyer changed the title Revert the $rootDir changes to the ContaoModuleBundle class Revert the $rootDir changes in the ContaoModuleBundle class Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp requested changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leofeyer @aschempp