Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock phpstan level 5 #1924

Merged
merged 21 commits into from
Jul 17, 2020
Merged

Unlock phpstan level 5 #1924

merged 21 commits into from
Jul 17, 2020

Commits on Jul 9, 2020

  1. upgrade phpstan level to 5

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    cecc5da View commit details
    Browse the repository at this point in the history

  2. report unmatched errors

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1b376cb View commit details
    Browse the repository at this point in the history

  3. drop unneeded rule exceptions 

    (+ minor adjustments in case of "a && b always evaluates to...")
    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8a9c0da View commit details
    Browse the repository at this point in the history

  4. fix invalid array arguments

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b32fbb8 View commit details
    Browse the repository at this point in the history

  5. remove/rewrite implicit type casting

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    013cbab View commit details
    Browse the repository at this point in the history

  6. fix parameter type annotations

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    40272d1 View commit details
    Browse the repository at this point in the history

  7. drop unnecessary (+ invalid) param type annotations from tests

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    135e0d0 View commit details
    Browse the repository at this point in the history

  8. drop tests that test for invalid but annotated types

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    baf6417 View commit details
    Browse the repository at this point in the history

  9. add exception for ContaoUserProviderTest testing with an invalid class 

    Here is why: The expected parameter is a UserInterface (enforced via UserProviderInterface) but only FrontendUser|BackendUser should be allowed. This type checking, however, is dynamically, so static analyzers cannot resolve it (= it must be annotated). The test is effectively validating the dynamic type check and therefore must be allowed to ignore the annotation.
    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b49947d View commit details
    Browse the repository at this point in the history

  10. fix tests

    @m-vo
    m-vo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d990f9a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2020

  1. revert preventing errors via \constant()

    @m-vo
    m-vo committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    1eb47e9 View commit details
    Browse the repository at this point in the history

  2. define BE_USER_LOGGED_IN as a dynamic constant

    @m-vo
    m-vo committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    63da7dd View commit details
    Browse the repository at this point in the history

  3. Revert dropping tests with invalid types / widening Image:set* types 

    This reverts commit baf6417 + partly reverts 40272d1
    @m-vo
    m-vo committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    3c5beba View commit details
    Browse the repository at this point in the history

  4. ignore tests intentionally calling legacy code with other types than… 

    … annotated
    @m-vo
    m-vo committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    daf0e04 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. remove verbose 'null' from 'mixed' type annotation

    @m-vo
    m-vo committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    a07ffbf View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. re-add annotation

    @m-vo
    m-vo committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    e3b80e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Merge branch 'master' into bugfix/unlock-phpstan-level-5

    @leofeyer
    leofeyer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    f18f3e5 View commit details
    Browse the repository at this point in the history

  2. Use @phpstan-ignore-next-line instead of adding ignoreErrors for sing… 

    …le issues
    @leofeyer
    leofeyer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    ef6603e View commit details
    Browse the repository at this point in the history

  3. Fix the phpDoc of the ImageFactory::create() method

    @leofeyer
    leofeyer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    c7a20c4 View commit details
    Browse the repository at this point in the history

  4. Fix the coding style

    @leofeyer
    leofeyer committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    af4cf5d View commit details
    Browse the repository at this point in the history

  5. revert strict check on $port

    @m-vo
    m-vo committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    77e2a4d View commit details
    Browse the repository at this point in the history