-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greatly simplify the PhpStan configuration #1948
Conversation
Gotta figure out tomorrow where the app cache is built now. 😄
|
"it even works" === no errors but less checks ;-) |
No errors could also mean not everything got tracked (afair). Otherwise it would not make sense for PHPStan to care about an additional extension for Symfony. |
Same with
What's the exact reason for? |
Is there a way to make PhpStan/Psalm show the number of tests run? |
The Not 100% sure what the |
I see, PHPStan got a lot better since our first steps with it 👍 |
May we have to add it again if we gain higher levels. Let's see. Apart from this LGTM. |
Description ----------- While trying to figure out contao#1940, I realized that we do not need `contao/phpstan` anymore in Contao 4.10. Commits ------- ab5a4cf Greatly simplify the PhpStan configuration 8baf34f Remove the phpstan/phpstan-symfony and psalm/plugin-symfony packages d70f85f Re-add the Symfony and Doctrine plugins
While trying to figure out #1940, I realized that we do not need
contao/phpstan
anymore in Contao 4.10.