Explicitly register the model classes

[leofeyer]

I have realized that using Model::getRelated() still relies on the old Contao 3 class autoloader to find the related model class. This is because Model::getClassFromTable() only converts tl_page to PageModel and not to Contao\PageModel and therefore we still have "composerized" classes in Contao 4.10 when we really should not anymore. 😄

This PR explicitly registers the fully qualified model class names.

[ausi]

Couldn’t we instead adjust the getClassFromTable method and return the class name with the Contao\ prefix if it exists?

[bytehead]

Couldn’t we instead adjust the getClassFromTable method and return the class name with the Contao\ prefix if it exists?

Thought about the same, but I'm not sure about potential side effects?

[fritzmg]

imho we should deprecate that functionality

[leofeyer]

Couldn’t we instead adjust the getClassFromTable method and return the class name with the Contao\ prefix if it exists?

Besides the potential side-effects, this would also be a BC break. Someone might have a class Vendor\PageModel and use $class = 'Vendor\\'.Model::getClassNameFromTable('tl_page').

[leofeyer]

imho we should deprecate that functionality

We can only deprecate it once we have an alternative. And Model::getRelated() somehow needs to determine the class name.

[fritzmg]

We can only deprecate it once we have an alternative. And Model::getRelated() somehow needs to determine the class name.

I only meant deprecating the automatic inference of the model class according to the table name instead of looking it up in TL_MODELS.

[aschempp]

I doubt you want to override $GLOBALS['TL_MODELS'] in every config file? 😂

[bytehead]

[ausi]

Besides the potential side-effects, this would also be a BC break. Someone might have a class Vendor\PageModel and use $class = 'Vendor\\'.Model::getClassNameFromTable('tl_page').

This would already fail if in the application config a custom class is registered via $GLOBALS['TL_MODELS']. IMO this is not a BC break, but if this method really gets used in such a way it might be better to not change it.

[leofeyer]

but if this method really gets used in such a way

It certainly was not intended to be used this way! But you know…

[leofeyer]

I doubt you want to override $GLOBALS['TL_MODELS'] in every config file? 😂

Fixed in 2016f09.

[ausi]

$class = 'Vendor\\'.Model::getClassFromTable('tl_page') would also break with this version of the pull request right?

[aschempp]

$class = 'Vendor\\'.Model::getClassFromTable('tl_page') would also break with this version of the pull request right?

I think it would. But that would be a bug in the extension code, which is easily fixable and fully backwards compatible.

[ausi]

But I agree, explicitly setting the class names should still be preferred. How about adding a deprecation notice here?

contao/core-bundle/src/Resources/contao/library/Contao/Model.php

Line 1191 in 9854bc5

(I think @fritzmg suggested something like that?)

[fritzmg]

Yep. Adding a deprecation notice there is what I meant :)

[leofeyer]

Deprecation added in c88a355.