Fix invalid "array to string conversion" in ScriptHandler exception message #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-vo
changed the title
fritzmg
approved these changes
Aug 23, 2020
|
Does this mean, the error only occurs, when the process fails nonetheless? I'm asking because I have a co-occurrence with another error in the console (either no error or two errors are shown in the console). |
|
Yes. If the process was't successful the adressed bug would prevent the error to be reported, though, because the error handling itself has an error 🙈. btw.: the error you're seeing might also be part of the regular output, that is streamed. |
|
Thank you @m-vo. |
m-vo
deleted the
bugfix/leftover-array-string-conversion-in-script-handler
branch
AlexejKossmann
pushed a commit
to AlexejKossmann/contao
that referenced
this pull request
Apr 6, 2021
…essage (see contao#2184) Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes contao/manager-bundle#88 | Docs PR or issue | - There is indeed a missing implode at this place. Commits ------- 83c3889 add a missing array->string conversion in the exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is indeed a missing implode at this place.